[Webkit-unassigned] [Bug 96592] Ruby text is incorrectly positioned when its writing-mode is changed to vertical after layout is done

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96592


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #191920|review?                     |review-
               Flag|                            |




--- Comment #15 from Hajime Morrita <morrita at google.com>  2013-03-10 23:00:51 PST ---
(From update of attachment 191920)
View in context: https://bugs.webkit.org/attachment.cgi?id=191920&action=review

The code looks good. ChangeLog needs a bit polish.

> Source/WebCore/ChangeLog:8
> +        Fix logical left of RenderRubyText is not cleared.

s/Fix/Fixed/ - WebKit usually uses past tense here.

> Source/WebCore/ChangeLog:10
> +        This cause trouble when RenderRubyTest is laid out as vertical after as horizontal.

s/causes/
s/as vertical/vertically/
s/as horizontal/horizontally/

> Source/WebCore/ChangeLog:13
> +        RenderRubyText::y remain old one.

You should explain not only what the problem was, but also how you fixed it.

> LayoutTests/ChangeLog:8
> +        Add a test that change block flow direction of Ruby after layout.

You don't need any extra description in this case. This is kinda obvious.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.