[Webkit-unassigned] [Bug 111472] Chromium - Find field display negative indexes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 10 14:25:34 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=111472


Sam Larison <qufighter at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abarth at webkit.org,
                   |                            |eric at webkit.org,
                   |                            |leandrogracia at chromium.org,
                   |                            |qufighter at gmail.com




--- Comment #4 from Sam Larison <qufighter at gmail.com>  2013-03-10 14:27:59 PST ---
Adding some people to the CC list who may have more familiarity with this code to aid in resolution of this bug.
https://code.google.com/p/chromium/issues/detail?id=130908

The line added by this patch fixes the chrome issue.  I am looking for some additional information from those who originally worked on this bit of code.  Maybe there is a good reason this variable is not reset during rest.

Unless m_locatingActiveRect becomes true we do not discover the correct index and end up with negative numbers in some circumstances as seen in the chrome issue.  When setting the reset parameter to true for scopeStringMatches, the function is not truly reset unless m_locatingActiveRect becomes true.

I can see there may be other ways to resolve the issue (calling the find function with certain parameters sets this variable to become true), however perhaps I might find a better understanding of the issue if I knew why m_locatingActiveRect isn't being reset during reset (speed?), because at least under some circumstances it seems like it should be set to true too, otherwise critical parts of scopeStringMatches are never reached.

I am running more tests to see if this resolves too.
https://code.google.com/p/chromium/issues/detail?id=162083

Thanks!
Sam

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list