[Webkit-unassigned] [Bug 110614] [GTK][WK2] Add document-loaded signal to WebKitWebPage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 10 09:25:18 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=110614


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #191698|review?                     |review-
               Flag|                            |




--- Comment #24 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-10 09:27:43 PST ---
(From update of attachment 191698)
View in context: https://bugs.webkit.org/attachment.cgi?id=191698&action=review

Found a small issue, see below.

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:52
> +    g_signal_emit(WEBKIT_WEB_PAGE(clientInfo), signals[DOCUMENT_LOADED], 0);

Add an early return here if this it not the main frame, we only want to emit this signal for the main frame.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list