[Webkit-unassigned] [Bug 105180] [GTK] When the WebProcess crashes, a signal should be emitted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105180





--- Comment #26 from Xan Lopez <xan.lopez at gmail.com>  2013-03-09 02:38:46 PST ---
(In reply to comment #24)
> (From update of attachment 192206 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192206&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1305
> > +    signals[WEB_PROCESS_CRASHED] = g_signal_new("web-process-crashed",
> 
> I usually move also the first parameter to the next line so that all parameters are lined up.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1308
> > +        0, 0, 0,
> 
> You should use G_STRUCT_OFFSET(WebKitWebViewClass, web_process_crashed),

Yeah, forgot that.

> Also maybe we could make this true handled, and if not handled by the user we can show a default crashed page like we do for error pages. For now we could just make this true handled without a default implementation and add it later.

If we do this then we'll have to solve the issue of showing a web page in a WebView whose web process just crashed. I assume it will be possible, but as we have seen it's apparently causing some bugs/crashes in Epiphany.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.