[Webkit-unassigned] [Bug 111892] equalIgnoringCase should take a const StringImpl* instead of StringImpl*

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 23:17:37 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=111892





--- Comment #5 from Eric Seidel <eric at webkit.org>  2013-03-08 23:20:02 PST ---
I'm not sure I'm going to actually fix this.  StringImpl.h is full of non-const StringImpl* arguments.  It seems to be the intentional style for that file?  I can sympathize with the desire to not spread the const disease.  And as ap/benp allude to, the current solution is not really ideal for the threaded parser.

We'll probably move to an enum-based system for the threaded parser, autogenerated by the make_names script in parallel to the existing QualifiedName tables.  This would be somewhat similar to our ancient enums before the dawn of QualifiedName and AtomicString. :)

I want the threaded parser files to be safe to play in w/o hurting yourself, and including HTMLNames (or any string globals) in those files makes them not so. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list