[Webkit-unassigned] [Bug 109404] Add selectTrailingWhitespaceEnabled setting to WebCore::Page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109404





--- Comment #38 from Tony Chang <tony at chromium.org>  2013-03-08 10:50:38 PST ---
(From update of attachment 192163)
View in context: https://bugs.webkit.org/attachment.cgi?id=192163&action=review

> Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:-417
> -    m_smartInsertDeleteEnabled = true;
> -#ifdef WIN32
> -    m_selectTrailingWhitespaceEnabled = true;
> -#else
> -    m_selectTrailingWhitespaceEnabled = false;
> -#endif

The Chromium test failures are because Chromium DRT has these default values, which are different from the Chromium browser defaults.  Calling the setter methods in the tests that failed will cause Chromium Win to probably fail some tests.  E.g., editing/pasteboard/smart-paste-00[78].html have different platform results (these tests are from before the testrunner methods setSmartInsertDeleteEnabled and setSelectTrailingWhitespaceEnabled when we had different baselines per platform).

I am sorry this is so complicated.

I think the right thing to do for chromium is in Tools/DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp, add these defaults in applyTo().

In the long term, we probably want to convert these tests to test both behavior and to have a shared expected result, but that's probably better as a separate patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.