[Webkit-unassigned] [Bug 111670] Implement pinch zoom for bottom-right fixed-position elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111670





--- Comment #5 from Sami Kyöstilä <skyostil at chromium.org>  2013-03-08 04:21:22 PST ---
(From update of attachment 191901)
View in context: https://bugs.webkit.org/attachment.cgi?id=191901&action=review

> Source/Platform/chromium/public/WebLayer.h:199
> +    virtual void setFixedToRightEdge(bool) { }

I wonder if we should have something more like the bitfields in the ViewportConstraints instead of this? That'll also cover cases where a layer is fixed to both edges on the same axis, in which case we may want to do something special in the compositor.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1921
> +RenderObject* RenderLayerCompositor::requiresFixedToContainerByRenderObject(const RenderLayer* layer) const

This function name is kinda hard to parse. Maybe fixedToContainerByRenderObject? The description doesn't seem to match the implementation since we can also return the layer itself (so the RenderObject won't be between the layer and its nearest compositor ancestor).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.