[Webkit-unassigned] [Bug 111641] Conformance Test 1.0.3 (Beta) function: bufferData undefined value failed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 02:25:03 PST 2013


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
 Attachment #191905|review?                     |review-
               Flag|                            |

--- Comment #3 from Dean Jackson <dino at apple.com>  2013-03-08 02:27:28 PST ---
(From update of attachment 191905)
View in context: https://bugs.webkit.org/attachment.cgi?id=191905&action=review

These may seem like nitpicking comments (and they are) but WebKit is especially strict about coding style. Sorry. You get used to it :) Make these easy fixes and the r+ is yours.

> Source/WebCore/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).
> +

In this space you should try to describe the bug and change in a little more detail. e.g. "The WebGL specification requires that buffer data cannot be of zero length. This is a new test in the Khronos 1.0.3 WebGL test suite."

Also, you should reference the Khronos test here. Typically we require a test for every WebKit commit, but in this case it's ok because we are in the process of incorporating the Khronos tests into WebKit, so it will be there eventually.

> Source/WebCore/ChangeLog:9
> +        (WebCore):

Remove this line.

> Source/WebCore/ChangeLog:10
> +        (WebCore::WebGLRenderingContext::bufferData):

You should always try to explain what you did in the changelog. In this case it is really easy - just something like "Synthesize error and return if size was 0."

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:1115
> +        // undefined in WEBGL will parse in 0.

No need for this comment. Also, for future reference, WebKit coding style requires comments to start with a capital letter.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list