[Webkit-unassigned] [Bug 103644] [GTK] Split GtkAuthenticationDialog in two widgets

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 02:22:11 PST 2013


--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-08 02:24:35 PST ---
(In reply to comment #11)
> (From update of attachment 189975 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189975&action=review

Thanks for the review.

> > Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:30
> > +    RefPtr<AuthenticationChallengeProxy> authenticationChallenge;
> There is a proper "public" API for this: WKAuthenticationChallenge (already used by Mac and EFL). Why can't it be used here?

It can be used. We switched long time ago to use only the internal API, because the code is a lot simpler, to avoid unnecessary casts and memory allocations in some cases. We didn't know this was a problem for Apple, I've always considered the C API as public for wk users not for the ports, and we indeed expose both APIs, so that WebKitGTK+ users can use the GTK+ high level API or the C API directly. Switching back to use the C API now would be a lot of work and we are currently at the end of our release cycle.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list