[Webkit-unassigned] [Bug 111786] New: Tighten up the type bounds for SVGPropertyInfo callback parameters

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 15:35:05 PST 2013


           Summary: Tighten up the type bounds for SVGPropertyInfo
                    callback parameters
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: fmalita at chromium.org
                CC: zimmermann at kde.org, krit at webkit.org,
                    inferno at chromium.org, pdr at google.com,
                    schenney at chromium.org

Currently, SVGPropertyInfo registers two callbacks with void* parameters: synchronizeProperty & lookupOrCreateWrapperForAnimatedProperty.

We should investigate converting these to SVGElement* parameters to facilitate type checking for the numerous static_casts in handlers. For example:

PassRefPtr<SVGAnimatedProperty> SVGViewSpec::lookupOrCreateViewBoxWrapper(void* maskedOwnerType)
    SVGViewSpec* ownerType = static_cast<SVGViewSpec*>(maskedOwnerType);

The conversion looks straightforward for the most part, with the noticeable exception of SVGViewSpec which is not a descendant of SVGElement.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list