[Webkit-unassigned] [Bug 111767] New: Build with debug flag breaks do to deprecated GTK Api

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111767

           Summary: Build with debug flag breaks do to deprecated GTK Api
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: luis at debethencourt.com


Building WebKitGtk with the --debug flag fails because of the use of GTK_WIDGET_SET_FLAGS() and GTK_WIDGET_UNSET_FLAGS() which have been deprecated in GTK+ since 2.22.
These are used in lines 225 and 227 of the file Source/WebCore/platform/gtk/RenderThemeGtk2.cpp

There is a comment saying:
// These functions are deprecated in GTK+ 2.22, yet theme engines still look
// at these flags when determining if a widget has focus, so we must use them.

But these flags are not publicly available anymore in GTK+3, and therefore can't be used at all. Done in the following commit:
https://mail.gnome.org/archives/commits-list/2010-May/msg08887.html
GTK_WIDGET_SET_FLAGS() used GTK_OBJECT_FLAGS() internally.

Since the proper way of setting the focus is:
g_object_set(widget, "has-focus", hasFocus, NULL);

and that line is already there, I propose to remove the GTK_WIDGET_SET_FLAGS() with the following patch, but I might be ignoring something important about the theme engines.

Anybody has any comments?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.