[Webkit-unassigned] [Bug 109404] Add selectTrailingWhitespaceEnabled setting to WebCore::Page

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 10:51:48 PST 2013


--- Comment #32 from Tony Chang <tony at chromium.org>  2013-03-07 10:54:10 PST ---
(From update of attachment 191944)
View in context: https://bugs.webkit.org/attachment.cgi?id=191944&action=review

This looks OK for the Chromium port.  I'm not sure if it's OK for all the other ports, although it doesn't look like you're removing any APIs.  Hmm, you might want someone to verify the changes to the mac port to verify that the NSUserDefaults behavior is being retained.

> Source/WebCore/page/Settings.in:199
> +# smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled are mutually
> +# exclusive, meaning that enabling one will disable the other.

I would remove this comment since it doesn't seem to be accurate anymore.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list