[Webkit-unassigned] [Bug 98270] [GTK][WK2] Add API to retrieve a snapshot from a webview

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98270





--- Comment #35 from Claudio Saavedra <csaavedra at igalia.com>  2013-03-07 07:27:23 PST ---
(From update of attachment 191951)
View in context: https://bugs.webkit.org/attachment.cgi?id=191951&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2936
>> +void WebKitWebViewDidReceiveSnapshotOfVisibleArea(WebKitWebView* webView, uint64_t callbackID, WebKit::WebImage* webImage)
> 
> First W should be lowercase. Also the OfVisibleArea sounds weird, since there are region options. webKitWebViewDidReceiveSnapshot() ? You don't need to use WebKit:: here in the cpp.

Name is a left-over from the previous code.

>> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:1141
>> +    surface1 = test->waitForSnapshot(WEBKIT_SNAPSHOT_REGION_VISIBLE, WEBKIT_SNAPSHOT_OPTIONS_NONE);
> 
> Does this returns an error too? It seems that finish() only returns NULL in case of error. Is it considered an error to ask for the snapshot of a visible region when the visible region is empty?

Yes, we consider it an error too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.