[Webkit-unassigned] [Bug 111675] When we set word-wrap: break-word and xml:space="preserve" to svg text element, the text is collapsed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111675


Stephen Chenney <schenney at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #191912|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Stephen Chenney <schenney at chromium.org>  2013-03-07 07:12:39 PST ---
(From update of attachment 191912)
View in context: https://bugs.webkit.org/attachment.cgi?id=191912&action=review

Mostly fine. I have one nit with the code and a request for greater testing.

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2841
> +                breakWords = breakAll = false;

I believe that WebKit style dictates that this be two lines, with one assignment on each line.

> LayoutTests/svg/text/preserve-break-word-expected.html:6
> +<text x="100" y="100" style="word-wrap: break-word">abcdef</text>

Can you remove the style on the <text>? As I understand your patch, the SVG should appear the same as something with no word-wrap defined.

> LayoutTests/svg/text/preserve-break-word.html:6
> +<text x="100" y="100" style="word-wrap: break-word"><tspan xml:space="preserve">abc</tspan>def</text>

Could you please provide 3 <text> nodes? One with word-wrap: break word, one with xml:space="preserve" and one with both (the line you have already is the one with both).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.