[Webkit-unassigned] [Bug 111714] New: [GTK][Refression] webkit_dom_html_table_element_insert_row returns value that doesn't pass WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT macro

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111714

           Summary: [GTK][Refression]
                    webkit_dom_html_table_element_insert_row returns value
                    that doesn't pass WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT
                    macro
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tpopela at redhat.com
                CC: xan.lopez at gmail.com, cgarcia at igalia.com


webkit_dom_html_table_element_insert_row returns value that doesn't pass WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT macro. It is caused by https://trac.webkit.org/changeset/137074 (git bisect get me to this). Here is some example code:

WebKitDOMElement* table = webkit_dom_document_get_element_by_id ( dom_document, table_id);

WebKitDOMHTMLElement* row = webkit_dom_html_table_element_insert_row ( WEBKIT_DOM_HTML_TABLE_ELEMENT (table), -1, NULL);

ASSERT (!WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT ((WebKitDOMHTMLTableRowElement *) row))

-> if you call this instead of ASSERT
WebKitDOMHTMLElement* cell = webkit_dom_html_table_row_element_insert_cell ( (WebKitDOMHTMLTableRowElement*) row, -1, NULL)
-> you get
** (evolution:16227): CRITICAL **: WebKitDOMHTMLElement* webkit_dom_html_table_row_element_insert_cell(WebKitDOMHTMLTableRowElement*, glong, GError**): assertion `WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT(self)' failed

Here is some code that is used in evolution:
https://git.gnome.org/browse/evolution/tree/modules/itip-formatter/itip-view.c?h=gnome-3-6#n909

Also this patch introduced another thing. When you receive invitation to some event in Evolution you will see TEXTAREA where you can comment this event. After this patch, when you are typing the comment and you will hit SPACE key it doesn't put space into TEXTAREA but instead it just goes to the next unread message (which is normal when you don't have focus on that TEXTAREA). Before this patchset everything was working fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.