[Webkit-unassigned] [Bug 111620] [GTK][WK2] Add webkit_uri_request_set_uri to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111620


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #191825|review?                     |review-
               Flag|                            |




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-06 23:11:35 PST ---
(From update of attachment 191825)
Thanks for the patch, but this has already been added, see patch in bug #83681, it hasn't landed in trunk yet because it's waiting for a WebKit2 owner, but landed in the stable branch already. In any case your patch has some issues, you are allowing the API to modify a construct only property, you should change the property to not be construct only, and use webkit_uri_request_set_uri()in the GObject setter too, emitting the notify signal when it changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.