[Webkit-unassigned] [Bug 111577] lint-test-files should warn when the test is skipped and has expectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 6 13:06:42 PST 2013


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
                 CC|                            |ojan at chromium.org

--- Comment #1 from Dirk Pranke <dpranke at chromium.org>  2013-03-06 13:09:07 PST ---
I don't think I understand what you're asking for ...

Are you asking for a change to lint-test-files, or the flakiness dashboard or both?

As far as lint-test-files goes, almost by design files later in the cascade are expected to have entries that override files earlier in the cascade (the original design for the cascade was callled "overrides"). So I would fully expect there to be entries overriding earlier files, and having lint-test-files warn about them would create a lot of noise.

Now, it is true that for non-chromium ports (meaning, ports that don't have keywords to limit the scope of a result), in order to scope an expectation to a particular port you *have* to use the cascade, and so there are cases where the expectations aren't overrides (or, at least, they're overriding "PASS").

But I don't know how you'd tell the difference between these two cases and avoid the noise.

Perhaps this makes more sense to warn for individual test cases (e.g. with webkit-patch print-expectations to have a flag or something), I dunno.

As far as the flakiness dashboard goes, are you saying that the showUnexpectedPasses page shouldn't be listing tests that are Skipped by default? I think that's probably a bug; it looks like the skipped=True flag is broken.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list