[Webkit-unassigned] [Bug 110375] Add client callbacks to notify of changes of associated from controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110375





--- Comment #80 from Ryosuke Niwa <rniwa at webkit.org>  2013-03-06 12:38:47 PST ---
(From update of attachment 191811)
View in context: https://bugs.webkit.org/attachment.cgi?id=191811&action=review

> Source/WebCore/ChangeLog:5
> +        Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded.
> +        Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields
> +        are dynamically created, autofill can know to re-query the autofill server and keep going.

As I pointed out on my previous comment, this long description of the patch should be below "Reviewed by" line followed by a blank line.
Just look at other change log entries.

> Source/WebCore/ChangeLog:10
> +        No new tests.

You should remove this line or explain why there is no new test.

> Source/WebCore/dom/Document.cpp:6088
> +    if (!this->frame())
> +        return;
> +    this->frame()->page()->chrome()->client()->didAssociateFormControls(m_associatedFormControls);

We don't need this->, do we?

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:1156
> +    HashSet<Element*>::iterator end = elements.end();
> +    for (HashSet<Element*>::iterator it = elements.begin(); it != end; ++it, ++i)
> +        elementVector[i] = WebNode(*it);

So sad we can't use copyToVector :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.