[Webkit-unassigned] [Bug 111591] [EFL][WK2] Separate WebView further from EwkView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111591





--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2013-03-06 12:38:45 PST ---
(In reply to comment #5)
> View in context: https://bugs.webkit.org/attachment.cgi?id=191794&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/EwkView.h:102
> > +    static EwkView* create(WebKit::WebView*, Evas* canvas, PassRefPtr<EwkContext> context, Evas_Smart* smart = 0);
> 
> Not sure about it. So far we have evas object that owns ewkview and ewkview owns webview, at least it is clearly determined how all those objects are created and deleted.

That is unchanged.

> Now it becomes more complicated.. like if WKViewCreateEvasObject was invoked web view memory management is done one way and if WKViewCreateEvasObject wasn't invoked it should be done totally different.

huh? It makes it possible to use the C API without EFL, which is the whole point. If you don't invoke it, you have to EwkView nor an Evas_Object.

> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:97
> > +static Evas_Object* internal_add_with_context(Evas* canvas, Ewk_Context* context, Evas_Smart* smart)
> 
> createView? createEvasObject?

It will go away when the EwkView doesn't store the EwkContext but just the C API one.

> > Source/WebKit2/UIProcess/efl/WebView.cpp:288
> > +    if (!m_ewkView)
> 
> think assertion is enough here. WebView will own its focus state after bug110877 is fixed.

Yes, it can be removed then, right now it will crash without this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.