[Webkit-unassigned] [Bug 103644] [GTK] Split GtkAuthenticationDialog in two widgets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103644





--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-06 00:55:25 PST ---
(From update of attachment 189975)
View in context: https://bugs.webkit.org/attachment.cgi?id=189975&action=review

Thanks for the review!

>> Source/WebKit/gtk/webkit/webkitauthenticationdialog.h:21
>> +
> 
> I think it's probably not needed here but I'd just add the G_BEGIN_DECLS stuff for consistency's sake.

We don't use those macros in private headers, I think it doesn't even compile, since this is not a C header but a C++ one.

>> Source/WebKit/gtk/webkit/webkitsoupauthdialog.cpp:27
>> +#include <wtf/text/CString.h>
> 
> This extra include seems odd?

GtkAuthenticationDialog.h included CString, and it's used in this file.

>> Source/autotools/Versions.m4:-18
>> -m4_define([gtk2_required_version], [2.10])
> 
> If it's not a pain in the ass I'd just try to not bump this, since the gtk2 stuff is on its way out and asking people to bump it for a very minor feature seems odd. But no strong feelings about it.

I don't think anybody will have to bump gtk version, 2.16 is already too old. I'm not even sure current wk builds with gtk 2.10.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.