[Webkit-unassigned] [Bug 107207] [V8] Support selectively wrapping DOM accesses from certain V8 contexts.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107207





--- Comment #13 from Kentaro Hara <haraken at chromium.org>  2013-03-05 16:47:27 PST ---
> > I'm interested in performance impacts when you enable the wrapping? Did you observe performance impacts on Dromaeo/dom-*.html or Bindings/* ?
> 
> I'll run the performance tests and get those numbers today.  I don't expect there to be any measurable overhead, since there are only a few extra machine instructions plus one extra memory access per DOM wrapper invocation. 
> 
> Note: If the perf cost is as low as I expect, this mechanism can be used for various types of optional monitoring---such as gathering of trace data---without any cost being incurred by normal operation.

hmm, I begin to wonder why this change is needed...:) It looks like the change is going to add unnecessary complexity to the code base. Also it is going to add "a few extra machine instructions plus one extra memory access", which sounds heavy (although we should judge it based on performance measurement).

What you want to do is adding wrapper methods for getters/setters/methods (selectively). Currently, xxxAttrGetterCallback(), xxxAttrSetterCallback() and xxxMethodCallback() are the entry points from V8. How about just hooking those entry points in code generators?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.