[Webkit-unassigned] [Bug 111434] [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111434





--- Comment #19 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-05 10:46:23 PST ---
(In reply to comment #18)
> This will serve to make the test independent of order, right?
> 
> diff --git a/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp b/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp
> index d5f3076..5c24643 100644
> --- a/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp
> +++ b/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp
> @@ -215,9 +215,6 @@ static void testWebViewFavicon(FaviconDatabaseTest* test, gconstpointer)
>      test->loadURI(kServer->getURIForPath("/foo").data());
>      test->waitUntilFaviconChanged();
>      g_assert(test->m_faviconNotificationReceived);
> -    // The icon is known and hasn't changed in the database, so notify::favicon is emitted
> -    // but WebKitFaviconDatabase::icon-changed isn't.
> -    g_assert(test->m_faviconURI.isNull());
> 
>      iconFromWebView = webkit_web_view_get_favicon(test->m_webView);
>      g_assert(iconFromWebView);

I don't think so, not that the test doesn't fail, but times out I guess because favicon changed is not emitted, I don't know

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.