[Webkit-unassigned] [Bug 111434] [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 10:23:39 PST 2013


--- Comment #15 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-05 10:26:04 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > That's a different issue, although related, can we just fix the tests so that I can make a release tomorrow and then you can fix it to make it order independent if you want?
> I'm not sure I understand the issue here. webkit_favicon_database_clear just calls removeAllIcons. It doesn't actually delete the database, does it? If so perhaps the API is broken, since the documentation doesn't mention that the favicon database does not work after calling it.

WebView favicon test assumes the icon is already in the database, see the comment in the test:

// The icon is known and hasn't changed in the database, so notify::favicon is emitted                                                                                                    
// but WebKitFaviconDatabase::icon-changed isn't.

Maybe that's wrong and it shouldn't make any assumption, but it's *another* issue.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list