[Webkit-unassigned] [Bug 111321] editing/execCommand/toggle-unlink.html needs to support different expectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 5 00:07:47 PST 2013


--- Comment #6 from Claudio Saavedra <csaavedra at igalia.com>  2013-03-05 00:10:11 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > (From update of attachment 191235 [details] [details] [details])
> > > The right fix is to make the behavior dependent on editing behavior and set editing behavior to mac in this test.
> > 
> > Wouldn't setting the editing behavior to Mac in this test be counter-productive? That would mean that, in this particular test, only the codepaths related to Mac would be tested, in all platforms. If the feature breaks for other platforms this test wouldn't catch it. How can that be better than having separate expectations for platforms that behave differently?
> You'll then add a new version of the test that tests Windows behavior.

This seems absolutely unnecessary to me. This is what different expectations per platform are for. The test shouldn't be hardcoding the expected outcome in its code. There are -expected.txt files that are meant to be used for that.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list