[Webkit-unassigned] [Bug 110291] Move WebCore feature defines to the WebCore directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110291


Laszlo Gombos <laszlo.gombos at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX




--- Comment #20 from Laszlo Gombos <laszlo.gombos at webkit.org>  2013-03-04 13:50:53 PST ---
(In reply to comment #19)

Thanks for the feedback.

Even though it seems that the idea was partially supported by a few, I do not feel strongly about this change, so I will close this bug as WONTFIX. I think having consensus on this matter that we as a project consistently follow going forward is more important.

> I think it's better to have the feature defines all in one place.

Maciej, I assume what you meant here is that there is a single entry point (FeatureDefines.h) for all WebKit configuration flags, but it does not necessary mean that all the configuration for all the ports are in a single header file. 

As described previously (https://lists.webkit.org/pipermail/webkit-dev/2013-January/023542.html) I assume that separating the port specific rules into port specific files are still a good idea.

FWIW, I have a WIP patch for EFL for how a port specific header file would look like - see bug 110717 .

My interpretation of the outcome of this discussion is that there is a consensus that the WTF directory is a good home for the WebKit wide configuration information.

I will file individual bugs for the work above, but please stop me now if you disagree with the direction.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.