[Webkit-unassigned] [Bug 105180] [GTK] When the WebProcess crashes, a signal should be emitted

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 11:30:17 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=105180





--- Comment #20 from Martin Robinson <mrobinson at webkit.org>  2013-03-04 11:32:40 PST ---
(From update of attachment 191033)
View in context: https://bugs.webkit.org/attachment.cgi?id=191033&action=review

Looks good to me. Some minor nits follow...

> Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:138
> +static void processDidCrash(WKPageRef page, const void *clientInfo)

Nit: the asterisk is in the wrong place.

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:186
>>  }
> 
> What I'm doing in other cases for the signal definition since this new style started to rely on my emacs automatic indentation is:
> 
> signals[WEB_PROCESS_CRASHED] = g_signal_new(
>     "web-process-crashed",
>     G_TYPE_FROM_CLASS(gObjectClass),
>     ....
> 
> That way I don't have to manually indent the lines, the style bot is happy and the code is kind of readable.

Yeah, I've switched this style too.

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp:62
> +        "/org/webkit/gtk/WebExtensionTest" , "org.webkit.gtk.WebExtensionTest", test->m_mainLoop));

Nit: extra space after the second "

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list