[Webkit-unassigned] [Bug 111288] [GTK][WK2] Add webkit_web_page_get_uri to WebKit2 GTK+ API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 02:06:37 PST 2013


--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-03-04 02:09:01 PST ---
(From update of attachment 191169)
View in context: https://bugs.webkit.org/attachment.cgi?id=191169&action=review

Patch looks good to me, thanks!

> Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp:291
> +    const char* uri;
> +    g_variant_get(result, "(&s)", &uri);
> +    g_assert_cmpstr(uri, ==, webkit_web_view_get_uri(test->m_webView));

Instead of testing only that the uris match, it would be interesting to test also that the uri is first /redirect and then /normal. You could add a class deriving from WebViewTest, because I think we don't need LoadTrackingTest for this particular test. The class could have a Vector of Strings where you add the current URI every time it changes. Then in the test you can use that vector to check that at 0 it's /redirect and at 1 it's /normal.

> Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp:377
> +

Remove this empty line.

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:193
> +    g_object_class_install_property(gObjectClass,

Move gObjectClass to the next line so that all parameters are lined up.

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:195
> +        g_param_spec_string("uri",

Ditto, move "uri"

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list