[Webkit-unassigned] [Bug 110291] Move WebCore feature defines to the WebCore directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110291





--- Comment #17 from Laszlo Gombos <laszlo.gombos at webkit.org>  2013-03-03 14:23:57 PST ---
(In reply to comment #16)

> I don't really understand what concrete problem this patch is try to solve.  I would just leave the header in WTF where it is at the base of the dependency diagram.

The goal is to have feature defines follow the same encapsulation/layering as the rest of the code. WebCore feature flags should not be exposed to WTF and/or JSC, yet they are defined in WTF. I believe the change increases code readability.  

2 benefits are listed in comment 2
 - One less file to maintain when a WebCore feature flags is added (FeatureDefines.xcconfig)
 - Changing WebCore feature-flags does not trigger a build for JSC or WTF.

It seems that there is an agreement to have a separate WebCoreFeatureDefines.h from the rest of the feature defines (PlatformFeatureDefines.h?).

We could certainly have some/most of the benefits and still leave the WebCoreFeatureDefines.h in WTF.

Would it make sense to move WebCoreFeatureDefines.h to Source/Platform instead ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.