[Webkit-unassigned] [Bug 110291] Move WebCore feature defines to the WebCore directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110291


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #191065|review?                     |review-
               Flag|                            |




--- Comment #10 from Adam Barth <abarth at webkit.org>  2013-03-02 23:27:45 PST ---
(From update of attachment 191065)
View in context: https://bugs.webkit.org/attachment.cgi?id=191065&action=review

> Source/WTF/wtf/FeatureDefines.h:-332
> -#if !defined(ENABLE_CANVAS_PATH)
> -#define ENABLE_CANVAS_PATH 1
> -#endif

What about these where the defaults are non-zero?

> Source/WTF/wtf/FeatureDefines.h:-344
> -#if !defined(ENABLE_CONTEXT_MENUS)
> -#define ENABLE_CONTEXT_MENUS 1
> -#endif

For example, this one isn't in features.gypi.

This seems very fragile!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.