[Webkit-unassigned] [Bug 111255] FormData.append should prefer application-specified filename to filename in a File

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 2 19:01:17 PST 2013


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #191114|commit-queue?               |commit-queue-
               Flag|                            |

--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2013-03-02 19:03:41 PST ---
(From update of attachment 191114)
View in context: https://bugs.webkit.org/attachment.cgi?id=191114&action=review

I don't have the time to look at code changes today, but wanted to make some comments about the test nonetheless. Please address these.

It is expected that the test fails on WebKit2. Please add it to expectations file next to other tests that fail because of beginDragWithFiles being unimplemented.

> LayoutTests/ChangeLog:12
> +        * http/tests/local/formdata/script-tests/send-form-data-with-filename.js: Added.
> +        (runTest):
> +        * http/tests/local/formdata/send-form-data-with-filename-expected.txt: Added.
> +        * http/tests/local/formdata/send-form-data-with-filename.html: Added.

Please don't split the test into two parts. We unfortunately still have many examples of this, but there really aren't any upsides, and many downsides to such splitting.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list