[Webkit-unassigned] [Bug 110939] Move markerTextForListItem from TestRunner to Internals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110939


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #191058|review?                     |review-
               Flag|                            |




--- Comment #8 from Benjamin Poulain <benjamin at webkit.org>  2013-03-01 16:12:19 PST ---
(From update of attachment 191058)
View in context: https://bugs.webkit.org/attachment.cgi?id=191058&action=review

> Source/WebCore/testing/Internals.cpp:2019
> +    return WebCore::markerTextForListItem(element);

Internals is in the WebCore namespace, you do not need the WebCore:: prefix here.

> Tools/DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:517
> -JSRetainPtr<JSStringRef> TestRunner::markerTextForListItem(JSContextRef context, JSValueRef nodeObject) const
> +JSRetainPtr<JSStringRef> TestRunner::layerTreeAsText() const
>  {
> -    WebCore::Element* element = toElement(toJS(toJS(context), nodeObject));
> -    if (!element)
> -        return 0;
> -
> -    JSRetainPtr<JSStringRef> markerText(Adopt, JSStringCreateWithUTF8CString(WebCore::markerTextForListItem(element).utf8().data()));
> -    return markerText;
> +    notImplemented();
> +    return 0;
>  }

Not sure why you change this to layerTreeAsText(). You can just remove all the code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.