[Webkit-unassigned] [Bug 115610] Add Support for mspace element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115610





--- Comment #54 from chris fleizach <cfleizach at apple.com>  2013-06-28 10:58:44 PST ---
(From update of attachment 205723)
View in context: https://bugs.webkit.org/attachment.cgi?id=205723&action=review

> Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:299
> +        lengthValue = 4 * floatValue / 3;

use parenthesis to make it clear what the order of operations are

> Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:30
> +#include "RenderMathMLSpace.h"

this should go right below config

> Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:48
> +bool RenderMathMLSpace::isChildAllowed(RenderObject*, RenderStyle*) const

this can be put in the header

> Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:57
> +    m_maxPreferredLogicalWidth = m_minPreferredLogicalWidth = m_width;

don't do cascading equals. put on separate line

> Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:67
> +    m_width = m_height = m_depth = 0;

ditto about equals

> Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:73
> +    if (m_width <= 0)

this should just be m_width < 0

> Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:77
> +    if (m_height + m_depth <= 0)

< 0 instead of <= 0. I would also add parens

> Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp:78
> +        m_height = m_depth = 0;

ditto about the equals

> Source/WebCore/rendering/mathml/RenderMathMLSpace.h:37
> +    RenderMathMLSpace(Element*);

explicit needed before the constructor

> Source/WebCore/rendering/mathml/RenderMathMLSpace.h:43
> +    virtual void updateFromElement();

are these also OVERRIDES?

can all these virtual methods move into private space

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.