[Webkit-unassigned] [Bug 117868] Texture unit code refactoring

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117868


Noam Rosenthal <noam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #205571|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #9 from Noam Rosenthal <noam at webkit.org>  2013-06-28 07:17:11 PST ---
(From update of attachment 205571)
View in context: https://bugs.webkit.org/attachment.cgi?id=205571&action=review

> Source/WebCore/ChangeLog:8
> +        According to OpenGL ES 2.0 specification there is not possible to use both

there -> it

> Source/WebCore/ChangeLog:11
> +        and makes WebKit more consistent with OpenGL

Period at end of sentence.

> Source/WebCore/ChangeLog:13
> +        No new tests. Covered by existing tests

ditto.
btw always nice to put a reference to one of the tests that covers this.

> Source/WebCore/html/canvas/WebGLRenderingContext.h:454
> +    struct TextureUnitState {
> +        RefPtr<WebGLTexture> m_textureBinding;
>      };

Does this need to be a struct?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.