[Webkit-unassigned] [Bug 118053] Parsing of MathML length

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118053





--- Comment #4 from Frédéric Wang <fred.wang at free.fr>  2013-06-26 13:38:07 PST ---
(In reply to comment #2)
> it looks like ParseNamedSpace is only used inside ParseLength… that method should be static inside the class file

As indicated in bug 115610 comment 5, I've made two separated functions because of mpadded attribute parsing which require calling the two functions plus doing some other stuff with pseudo-units. However, this is not implemented in WebKit yet, so I can make ParseNamedSpace static for the moment.

> 
> > Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:82
> > +        ParseLength(thickness, m_lineThickness, false);
> 
> you might want to check if the conversion succeeded before setting the value

Not sure what you mean here... m_lineThickness = gLineMedium sets m_lineThickness to the default value. If ParseLength fails, then the attribute is ignored and the default value is used. If ParseLength succeeds, then m_lineThickness is set to the parsed value (perhaps a multiple of the specified default for % and unitless). So the boolean success result is not really used here, but I think it may be useful in other situations.

I'd like to have clarification on what you expect exactly for the tests and about this last point before submitting a new version.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.