[Webkit-unassigned] [Bug 118053] Parsing of MathML length

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118053





--- Comment #3 from Frédéric Wang <fred.wang at free.fr>  2013-06-26 13:04:34 PST ---
(In reply to comment #2)
> (From update of attachment 205475 [details])
> none of the tests have expected results
>
> what is this testing? there is nothing about math in this test
> 
> these thickness tests should be in one line thickness test. i don't think we need separate files for each one

Thanks Chris. I don't know if you've seen my comments on bug 115610, but it seems that we have a misunderstanding about what these tests are. You seem to expect some other particular unit test format but note that I have used reftests:

http://trac.webkit.org/wiki/Writing%20Reftests

So basically the two pages

   mathml/presentation/mfrac-linethickness1.html
   mathml/presentation/mfrac-linethickness1-expected-mismatch.html

form one != reftests that is the test passes iff they don't render the same while the pair

   mathml/presentation/mfrac-linethickness2.html
   mathml/presentation/mfrac-linethickness2-expected-mismatch.html

forms one == reftest that is the test passes iff the two pages render exactly the same. Similarly for -3 -4 and -5.

Also note that by design it is clear that we can not group == and != reftests in the same test. It's perhaps less obvious, but we can not group != reftests in the same test either. However, I can group the == reftests in the same test if you want.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.