[Webkit-unassigned] [Bug 117786] Change recently ratified extensions prefixes from WEBKIT_WEBGL_ to WEBGL_

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117786





--- Comment #7 from Christophe Dumez <dchris at gmail.com>  2013-06-26 07:29:06 PST ---
(In reply to comment #6)
> (In reply to comment #2)
> > (From update of attachment 204975 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=204975&action=review
> > 
> > > Source/WebCore/html/canvas/WebGLRenderingContext.cpp:-2414
> > > -        || equalIgnoringCase(name, "WEBKIT_WEBGL_lose_context")
> > 
> > Is it safe to remove these checks?? Seems blink still has the checks in place.
> 
> Hey, i dug recently into blink/chrom code, and found out, that they are not using WEBKIT_ prefix anymore:
> 
> https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/html/canvas/WebGLLoseContext.cpp&q=WEBGL_lose_context&sq=package:chromium&type=cs&l=79
> 
> https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/html/canvas/WebGLDepthTexture.cpp&q=WEBGL_depth_texture&sq=package:chromium&type=cs
> 
> https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/html/canvas/WebGLCompressedTextureS3TC.cpp&q=WEBGL_compressed_texture_s3tc&sq=package:chromium&type=cs

This is inaccurate I believe, take a look at WebGLRenderingContext::ExtensionTracker::matchesNameWithPrefixes(). The code was merely refactored.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.