[Webkit-unassigned] [Bug 117868] Texture unit code refactoring

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 26 06:35:52 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=117868


Noam Rosenthal <noam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #205172|review?                     |review-
               Flag|                            |




--- Comment #6 from Noam Rosenthal <noam at webkit.org>  2013-06-26 06:37:47 PST ---
(From update of attachment 205172)
View in context: https://bugs.webkit.org/attachment.cgi?id=205172&action=review

R- due to missing changelog.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:-612
> -      m_textureUnits[i].m_texture2DBinding = 0;

4 spaces for indent please

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4811
> +            const GC3Denum target = m_textureUnits[ii].m_textureBinding->getTarget();

We don't use local const in webkit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list