[Webkit-unassigned] [Bug 116897] [Qt] Build overrides -j when given --makeargs="-sj40"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116897


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203103|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Csaba Osztrogonac <ossy at webkit.org>  2013-06-26 01:07:47 PST ---
(From update of attachment 203103)
View in context: https://bugs.webkit.org/attachment.cgi?id=203103&action=review

> Tools/Scripts/webkitdirs.pm:2227
> -    if ($make eq "make" && $makeargs !~ /-j\s*\d+/i && (!defined $ENV{"MAKEFLAGS"} || ($ENV{"MAKEFLAGS"} !~ /-j\s*\d+/i ))) {
> +    if ($make eq "make" && $makeargs !~ /-[^\s]*?j\s*\d+/i && (!defined $ENV{"MAKEFLAGS"} || ($ENV{"MAKEFLAGS"} !~ /-j\s*\d+/i ))) {

LGTM, but please fix the regexp of MAKEFLAGS too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.