[Webkit-unassigned] [Bug 118050] [curl] Fix unused variable/parameter warnings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 26 00:41:14 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118050





--- Comment #3 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-06-26 00:43:10 PST ---
(In reply to comment #2)
> Attachment 205459 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/curl/CredentialStorageCurl.cpp', u'Source/WebCore/platform/network/curl/DNSCurl.cpp', u'Source/WebCore/platform/network/curl/ResourceHandleManager.cpp']" exit_code: 1
> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:118:  curl_lock_callback is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:124:  curl_unlock_callback is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> Total errors found: 2 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

I don't think we should address this in this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list