[Webkit-unassigned] [Bug 117998] need mechanism to detect (partially) hidden blocked plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117998





--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-06-25 11:05:45 PST ---
(From update of attachment 205411)
View in context: https://bugs.webkit.org/attachment.cgi?id=205411&action=review

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:286
> +    TextRun run("");

Does this have to be initialized with an empty string?

> Source/WebCore/rendering/RenderEmbeddedObject.h:54
> +    bool replacementFitsInContentBoxRect() const;

It's not clear from the interface what "replacement" means. Is there a better term to use?

> Source/WebKit2/Shared/Plugins/Netscape/PluginInformation.cpp:123
> +PassRefPtr<ImmutableDictionary> createPluginInformationDictionary(const PluginModuleInfo& plugin, const String& frameURLString, const String& mimeType, const String& pageURLString, const String& pluginspageAttributeURLString, const String& pluginURLString, bool replacementMayBePartiallyHidden)

You could provide a default value of false for replacementMayBePartiallyHidden to avoid mysterious 'false' at call sites.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:556
> +            replacementMayBePartiallyHidden = renderObject->style()->visibility() != VISIBLE || !renderObject->replacementFitsInContentBoxRect();

It's a bit odd to have this visibility check here. It's one of many reasons why the plug-in may not be visible, and, if we were to make this check more complex, putting more code here would not make sense. We could add a new function to RenderEmbeddedObject, or even something more general on, say, RenderBox.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.