[Webkit-unassigned] [Bug 83056] Serializing SVG removes namespace from attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83056





--- Comment #9 from Alex Milowski <alex at milowski.com>  2013-06-24 14:35:33 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > Sure.  That makes sense.  
> > 
> > I don't know what the policy is for closing bugs like this.  Certainly the problem described for that particular page is fixed within the current code.
> 
> Well, the latest patch on bug 16496 fixes both of the problems in your testcase. So once that goes in, we can close this bug too, though we have to check whether we want to keep your testcase in the tests.

I took a peek at this patch.  It doesn't look like it handles the general problems with the serializer but certainly can address issues with the SVG and xlink namespace/prefix.

The real fix requires an adjustment to the algorithm to keep track of generated prefixes and/or their declaration.  That is, you need to general prefixes as necessary, not just for known namespaces, and the keep track of their scope.  Neither of those happen currently in the MarkupAccumulator.cpp code.

See bug 117764 for some more esoteric examples of where this breaks down.

That said, I'm happy to close out specific bugs with smaller changes and wait for the general one to be addressed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.