[Webkit-unassigned] [Bug 117294] [WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117294


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #205171|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #12 from Brent Fulgham <bfulgham at webkit.org>  2013-06-21 09:48:09 PST ---
(From update of attachment 205171)
View in context: https://bugs.webkit.org/attachment.cgi?id=205171&action=review

I don't think this patch is quite right.  The SchedulePair header and implementations both refer to CoreFoundation types.  It may be that you can build without CoreFoundation in cases where the underlying code using these headers do not happen to call code that actually needs access to CoreFoundation symbols, but this really isn't right as some seemingly unrelated future change could suddenly cause the build to break.

Instead, we need to make Debug_WinCairo and Release_WinCairo targets for WTF that link to CFLite.lib instead of CoreFoundation.lib so that the calls to CFEqual and use of various CF types will resolve to real symbols at link time.

> Source/WTF/WTF.vcxproj/WTFCommon.props:26
> +      <AdditionalDependencies>winmm.lib;libicuuc$(DebugSuffix).lib;libicuin$(DebugSuffix).lib;%(AdditionalDependencies)</AdditionalDependencies>

While it is good to remove the CoreFoundation.lib dependency here, we should be using CFLite on the WinCairo build.

> Source/WTF/WTF.vcxproj/WTFDebug.props:15
> +    </Link>

This property sheet still requires CoreFoundation.lib for WinCairo builds.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.