[Webkit-unassigned] [Bug 117794] [EFL][WK2] Implement unit test callback: onWordGuesses

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117794





--- Comment #13 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2013-06-20 23:39:10 PST ---
(From update of attachment 205073)
View in context: https://bugs.webkit.org/attachment.cgi?id=205073&action=review

The code itself looks fine. Added one nit regarding to the EFL's spellchecking.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:629
>      ewk_text_checker_word_guesses_get_cb_set(onWordGuesses);

Setting this callback affects other text checker tests that will be launched after this one. Could you invalidate it by setting 0 at the end of the test? You've already done it in onSettingChange test. Would be nice to add an additional line then, to point clearing part of the test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.