[Webkit-unassigned] [Bug 117281] Crash in V8 benchmarks set in ARM, softfp, EABI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117281





--- Comment #25 from Youngho Yoo <youngho33.yoo at lge.com>  2013-06-20 10:05:25 PST ---
(In reply to comment #23)
> This bug is a duplicate of https://bugs.webkit.org/show_bug.cgi?id=116315
> There I created a smaller patch which suits ARM EABI (hardfp and softfp), but I didn't take non-EABI ARM case into account. The patch presented here doesn't have such a drawback and in general looks correct, but my approach seems to be more straightforward. It can be modified to support non-EABI using one #if section (are there actually any ARM targets that don't use EABI?).
> My patch contains two layout tests, it is possible to use them for this patch.

I think your patch is straightforward.
But if you add #if DFG DFGCCallHelpers.h,
It needs two maintencance points for EABI things.
That's why I just follow DFGSpeculativeJIT.h's convention.
And your regression tests is LGTM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.