[Webkit-unassigned] [Bug 117789] [Qt][WK2] Add WebKit2 Pointer Lock Implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 20 05:36:13 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=117789





--- Comment #5 from WebKit Commit Bot <commit-queue at webkit.org>  2013-06-20 05:34:52 PST ---
Attachment 205075 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/qt-5.0-wk2/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/Target.pri', u'Source/WebCore/page/PointerLockController.cpp', u'Source/WebCore/page/PointerLockController.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/DerivedSources.pri', u'Source/WebKit2/Shared/API/c/WKBase.h', u'Source/WebKit2/Shared/APIClientTraits.cpp', u'Source/WebKit2/Shared/APIClientTraits.h', u'Source/WebKit2/Shared/APIObject.h', u'Source/WebKit2/Shared/WebEventConversion.cpp', u'Source/WebKit2/Shared/WebProcessCreationParameters.cpp', u'Source/WebKit2/Shared/WebProcessCreationParameters.h', u'Source/WebKit2/Target.pri', u'Source/WebKit2/UIProcess/API/C/WKAPICast.h', u'Source/WebKit2/UIProcess/API/C/WKContext.cpp', u'Source/WebKit2/UIProcess/API/C/WKContext.h', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/API/C/WKPointerLockPermissionManager.cpp', u'Source/WebKit2/UIProcess/API/C/WKPointerLockPermissionManager.h', u'Source/WebKit2/UIProcess/API/C/WKPointerLockPermissionProvider.h', u'Source/WebKit2/UIProcess/API/C/WKPointerLockPermissionRequest.cpp', u'Source/WebKit2/UIProcess/API/C/WKPointerLockPermissionRequest.h', u'Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp', u'Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h', u'Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h', u'Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp', u'Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest_p.h', u'Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_pointerlock.qml', u'Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/pointerlock1.html', u'Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/pointerlock2.html', u'Source/WebKit2/UIProcess/PointerLock/PointerLockPermissionRequest.cpp', u'Source/WebKit2/UIProcess/PointerLock/PointerLockPermissionRequest.h', u'Source/WebKit2/UIProcess/PointerLock/PointerLockPermissionRequestManagerProxy.cpp', u'Source/WebKit2/UIProcess/PointerLock/PointerLockPermissionRequestManagerProxy.h', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockManagerProxy.cpp', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockManagerProxy.h', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockManagerProxy.messages.in', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockPermissionManagerProxy.cpp', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockPermissionManagerProxy.h', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockPermissionProvider.cpp', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockPermissionProvider.h', u'Source/WebKit2/UIProcess/PointerLock/qt/WebPointerLockManagerProxyQt.cpp', u'Source/WebKit2/UIProcess/WebContext.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/UIProcess/WebUIClient.cpp', u'Source/WebKit2/UIProcess/WebUIClient.h', u'Source/WebKit2/UIProcess/qt/QtDialogRunner.h', u'Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp', u'Source/WebKit2/UIProcess/qt/QtWebPageUIClient.h', u'Source/WebKit2/WebKit2.pri', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePagePointerLockClient.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePagePointerLockClient.h', u'Source/WebKit2/WebProcess/PointerLock/PointerLockPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/PointerLock/PointerLockPermissionRequestManager.h', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockManager.cpp', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockManager.h', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockManager.messages.in', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockPermissionCallback.cpp', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockPermissionCallback.h', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockPermissionManager.cpp', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockPermissionManager.h', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockPermissionManager.messages.in', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.messages.in', u'Source/WebKit2/WebProcess/WebProcess.cpp', u'Tools/ChangeLog', u'Tools/MiniBrowser/qt/MiniBrowserApplication.cpp', u'Tools/MiniBrowser/qt/qml/BrowserWindow.qml', u'Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl', u'Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp', u'Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h', u'Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp', u'Tools/WebKitTestRunner/InjectedBundle/TestRunner.h', u'Tools/WebKitTestRunner/Target.pri', u'Tools/WebKitTestRunner/TestController.cpp', u'Tools/WebKitTestRunner/TestController.h', u'Tools/WebKitTestRunner/WebPointerLockPermissionProvider.cpp', u'Tools/WebKitTestRunner/WebPointerLockPermissionProvider.h', u'Tools/qmake/mkspecs/features/features.pri']" exit_code: 1
Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp:78:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest_p.h:66:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list