[Webkit-unassigned] [Bug 73743] [GStreamer] webkitwebsrc: use SubResourceLoader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73743





--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-06-20 02:37:06 PST ---
(In reply to comment #10)
> (From update of attachment 205025 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205025&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:1027
> > +    if (resource->loadFailedOrCanceled()) {
> 
> Ok, what about errorOccured()? Shouldn't it be checked too?

This should be covered already, error handling of cached resources is a bit confusing, I think. errorOccurred() checks id status is LoadError or DecodeError. DecodeError is only used by Font and Image subresources, so we only need to care about load errors. When a subresource fails to load, setResourceError is called (so loadFailedOrCanceled() is true) and then LoadError is set (so errorOccured() is true). When a subresource is cancelled, willCancel calls setResourceError and didCancel calls didCancelLoad that sets the status to LoadError. 

What we could do is get the actual ResourceError to provide some more information like current code does. I'll update the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.