[Webkit-unassigned] [Bug 117281] Crash in V8 benchmarks set in ARM, softfp, EABI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117281





--- Comment #18 from Mark Lam <mark.lam at apple.com>  2013-06-19 17:53:35 PST ---
(From update of attachment 203943)
View in context: https://bugs.webkit.org/attachment.cgi?id=203943&action=review

LGTM after you fix the ChangeLog, but need a reviewer to r+.

>>> Source/JavaScriptCore/dfg/DFGCCallHelpers.h:571
>>> +    }
>> 
>> It seems these are not use in the ARM_HARDFP port.  I see no reason to add them.
> 
> But this is for EABI, ARM_HARDFP port. (relate with @1396, at 1494)
> Is ARM_HARDFP port doesn't using EABI?
> If or not, I will remove them.

OK, I was mistaken.  Please disregard my comment.

>>> Source/JavaScriptCore/dfg/DFGCCallHelpers.h:615
>>> +    }
>> 
>> In the !ARM_HARDFP port, these replaces "setupArgumentsWithExecState(FPRReg arg1, GPRReg arg2)" and "setupArgumentsWithExecState(GPRReg arg1, GPRReg arg2, FPRReg arg3)".  Remove the now unused functions.
> 
> Similar reason like upper things.
> But "setupArgumentsWithExecState(FPRReg arg1, GPRReg arg2)" and "setupArgumentsWithExecState(GPRReg arg1, GPRReg arg2, FPRReg arg3)" is for nonEABI, !ARM_HARDFP port. (relate with @1396, at 1494)
> If there is no nonEABI and !ARM_HARDFP port, I will remove them.

I was mistaken.  Please disregard my comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.