[Webkit-unassigned] [Bug 117730] [ATK] Added support for aria-required attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117730





--- Comment #6 from Krzysztof Czech <k.czech at samsung.com>  2013-06-19 04:37:29 PST ---
(In reply to comment #5)
> (From update of attachment 204912 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204912&action=review
> 
> Why does these tests need to be efl/gtk only? they look like they could pass on the Mac without issue as well.
Yes you are right, they're all passing on mac as well. Basically, those two tests are already in mac. I guess moving them to LayoutTests/accessibility it's a good idea. I wasn't really sure about moving them. Thanks.

> There are also a few accessibility "required" tests that already exist. Do those provide the same coverage? Can they be unskilled by GTK?
Right, I think there are 3 accessibility "required" tests. Those two I'm moving are passing on GTK/EFL port, other one it's not.
> 
> > LayoutTests/platform/efl/accessibility/aria-required.html:25
> > +          var succeeded = obj.isRequired;
> 
> Before outputting these results it would be nice to explain what is being tested like
> debug("Verify that isRequired is true when aria-required=true");
> So that a failing case is easy to diagnose
> 
> > LayoutTests/platform/efl/accessibility/aria-required.html:26
> > +          shouldBe("succeeded", "true");
> 
> for these, it would be preferable to write
> shouldBeTrue("obj.isRequired")
> 
> which will give more context if they fail

+ var succeeded = !obj.isRequired;
+ shouldBe("succeeded", "true");
I think, this might be change to shouldBeFalse("obj.isRequired") since we are
expecting to be false.

Thanks for your suggestions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.