[Webkit-unassigned] [Bug 117728] [EFL][WK2] Implement unit test callback: onSettingChange

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117728





--- Comment #17 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2013-06-19 02:35:05 PST ---
(From update of attachment 204976)
View in context: https://bugs.webkit.org/attachment.cgi?id=204976&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:228
> +static Ewk_Context_Menu_Item* findContextMenuItem(const Ewk_Context_Menu* contextMenu, const Ewk_Context_Menu_Item_Action& itemAction, const Ewk_Context_Menu_Item_Type& itemType)

Chris mentioned that passing enum (itemAction, itemType) as const reference is not recommended.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:242
> +    }
> +    ADD_FAILURE();
> +
> +    return 0;

Sorry, I clicked wrong line, I meant :
}

ADD_FAILURE();
return 0;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.