[Webkit-unassigned] [Bug 117667] Expose a getMediaType method in WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117667





--- Comment #16 from Ruth Fong <ruthiecftg at gmail.com>  2013-06-18 12:33:51 PST ---
(From update of attachment 204869)
View in context: https://bugs.webkit.org/attachment.cgi?id=204869&action=review

>> Source/WebKit2/UIProcess/API/C/WKAPICast.h:176
>> +    return kWKBundleHitTestResultMediaTypeNone;
> 
> ASSERT_NOT_REACHED() here also, right?

None of the other toAPI methods include the ASSERT_NOT_REACHED() (not sure why)

>> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:32
>> +#include <WebKit2/WKBundleHitTestResult.h>
> 
> These headers are local to the WK2 project, so it should just be #include "InjectedBundleHitTestResultMediaType.h" under the APIObject include.
> 
> And the WKBundleHitTestResult.h include isn't needed at all - that's what we're avoiding with all these casts and such!

Got it.

>> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:84
>> +    return toImpl(hitTestResultRef)->getMediaType();
> 
> This needs to be:
> return toAPI(toImpl(hitTestResultRef)->getMediaType()) to perform the InjectedBundle* -> WKBundle* cast

Got it (it seemed to work without the cast...)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.